Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ContainerAuthenticator): enhance ContainerAuthenticator to support Code Engine workload #296

Merged

Conversation

SaschaSchwarze0
Copy link
Member

This pull request extends the existing ContainerAuthenticator to be aware of the hard-coded compute resource token path used by Code Engine. This allows a seamless usage of that authenticator and a move of workload between IKS/ROKS/Code Engine without changing a single line of code.

Documentation is adjusted to mention Code Engine in the context of the ContainerAuthenticator.

@CLAassistant
Copy link

CLAassistant commented Mar 3, 2025

CLA assistant check
All committers have signed the CLA.

@SaschaSchwarze0 SaschaSchwarze0 force-pushed the sascha-container-authenticator-code-engine branch from 9d25e01 to d67b8c0 Compare March 3, 2025 13:47
@padamstx padamstx requested review from padamstx and dpopp07 March 6, 2025 23:49
@padamstx padamstx self-assigned this Mar 6, 2025
@padamstx
Copy link
Member

padamstx commented Mar 6, 2025

@SaschaSchwarze0 Looks like there were some lint-related errors during the build. In your local sandbox you can run npm run fix to fix most lint errors automatically, then address any remaining errors manually.
To do a lint-check (without trying to fix anything), run npm run lint.

Copy link
Member

@padamstx padamstx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good. Just need to address the linter errors.

@SaschaSchwarze0 SaschaSchwarze0 force-pushed the sascha-container-authenticator-code-engine branch from 115ffb3 to 7738eda Compare March 7, 2025 08:49
…rt Code Engine workload

Signed-off-by: Sascha Schwarze <[email protected]>
@SaschaSchwarze0 SaschaSchwarze0 force-pushed the sascha-container-authenticator-code-engine branch from 7738eda to e264596 Compare March 7, 2025 08:51
@SaschaSchwarze0 SaschaSchwarze0 requested a review from padamstx March 7, 2025 08:54
Copy link
Member

@padamstx padamstx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@dpopp07 dpopp07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍

Thanks @SaschaSchwarze0 !

@dpopp07 dpopp07 merged commit f8e2b43 into IBM:main Mar 7, 2025
7 checks passed
ibm-devx-sdk pushed a commit that referenced this pull request Mar 7, 2025
# [5.3.0](v5.2.0...v5.3.0) (2025-03-07)

### Features

* **ContainerAuthenticator:** add support for code engine workload ([#296](#296)) ([f8e2b43](f8e2b43))
@ibm-devx-sdk
Copy link

🎉 This PR is included in version 5.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants