-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ContainerAuthenticator): enhance ContainerAuthenticator to support Code Engine workload #296
feat(ContainerAuthenticator): enhance ContainerAuthenticator to support Code Engine workload #296
Conversation
9d25e01
to
d67b8c0
Compare
@SaschaSchwarze0 Looks like there were some lint-related errors during the build. In your local sandbox you can run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good. Just need to address the linter errors.
115ffb3
to
7738eda
Compare
…rt Code Engine workload Signed-off-by: Sascha Schwarze <[email protected]>
7738eda
to
e264596
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! 👍
Thanks @SaschaSchwarze0 !
# [5.3.0](v5.2.0...v5.3.0) (2025-03-07) ### Features * **ContainerAuthenticator:** add support for code engine workload ([#296](#296)) ([f8e2b43](f8e2b43))
🎉 This PR is included in version 5.3.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
This pull request extends the existing ContainerAuthenticator to be aware of the hard-coded compute resource token path used by Code Engine. This allows a seamless usage of that authenticator and a move of workload between IKS/ROKS/Code Engine without changing a single line of code.
Documentation is adjusted to mention Code Engine in the context of the ContainerAuthenticator.